BaseVaultTest refactoring #1196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EndymionJkb
approved these changes
Dec 24, 2024
| @@ -75,19 +75,19 @@ contract BigPoolDataTest is BaseVaultTest { | |||
| vm.stopPrank(); | |||
| } | |||
|
|
|||
| function _approveForSender() internal { | |||
| function _approveNewPoolForSender() internal { | |||
There was a problem hiding this comment.
There are several similar functions here that are identical except for the target of the loop. Consider factoring it out into BaseVaultTest (maybe with an argument for the array). For instance, BigWeightedPool.t.sol's _approvePoolTokensForSender / _approvePoolTokensForPool; and here _approveNewPoolForSender / _approveForNewPool
Co-authored-by: EndymionJkb <[email protected]>
jubeira
approved these changes
Dec 30, 2024
There was a problem hiding this comment.
LGTM, makes sense!
Agree with this comment too: https://github.com/balancer/balancer-v3-monorepo/pull/1196/files#r1896319207
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes variables that are used as constants actually constant and also adds some hooks for more flexible lifecycle customization.
Type of change
Checklist:
main, or there's a description of how to mergeIssue Resolution